Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2174 +/- ##
==========================================
- Coverage 91.18% 89.85% -1.33%
==========================================
Files 67 73 +6
Lines 16489 19006 +2517
==========================================
+ Hits 15035 17078 +2043
- Misses 1454 1928 +474
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ni-jfitzger
left a comment
There was a problem hiding this comment.
I'm not going to tell you to remove this function, since we spent enough time going over the API already and we ship this in at least a couple of other APIs, but I honestly have no idea what purpose it serves in our Python API. We already handle errors for the user with get_error().
@marcoskirsch do you know why we included this in other APIs?
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR fixes
error_messagemethod in nifrsg. The ErrorMessage parameter was passed as an input parameter, but the niRFSG_ErrorMessage C API returns the error string.Changes:
errorMessageparameter direction from 'in' to 'out' in nirfsg metadata.List issues fixed by this Pull Request below, if any.
What testing has been done?
errorMessagetreated as an output parameter instead ofinputparameter.