adopt ni/python-actions for PR builds#235
Merged
Conversation
Contributor
|
Thank you for contributing! 👋 |
bkeryan
requested changes
Sep 11, 2025
f30f9ad to
be6197a
Compare
bkeryan
reviewed
Nov 14, 2025
bkeryan
approved these changes
Nov 14, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the CI/CD pipeline to use standardized actions from ni/python-actions and modernizes Python version support by dropping Python 3.8 and adding Python 3.14 (including the free-threaded variant).
Key changes:
- Updated minimum Python version from 3.8 to 3.9
- Adopted ni/python-actions templates for setup-python, setup-poetry, and analyze-project steps
- Added Python 3.14 and 3.14t (free-threaded) to the test matrix
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updated minimum Python version to 3.9 and simplified flake8-tidy-imports dependency constraint |
| poetry.toml | Added configuration to create virtualenvs in-project for better CI caching |
| poetry.lock | Updated lock file to reflect Python 3.9 minimum and removed flake8-tidy-imports 4.10.0 |
| .github/workflows/PR.yml | Migrated to ni/python-actions, expanded checks to run on all platforms, and added Python 3.14/3.14t support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
irwand
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
We are aligning on action templates in ni/python-actions
The publishing code was already moved over to unblock it, now, let's get the PR pipelines switched over as well.
Major changes
Testing
PR should execute the modified actions