fix: support signing unsigned Mach-O binaries without LC_CODE_SIGNATURE#44
Open
messense wants to merge 2 commits intonichmor:mainfrom
Open
fix: support signing unsigned Mach-O binaries without LC_CODE_SIGNATURE#44messense wants to merge 2 commits intonichmor:mainfrom
messense wants to merge 2 commits intonichmor:mainfrom
Conversation
Add support for ad-hoc signing Mach-O binaries that don't have an existing LC_CODE_SIGNATURE load command (unsigned binaries). Changes: - Add write_u32/write_u64 helpers that respect binary endianness (ctx.le) instead of hardcoded .to_le_bytes() - Extract InsertCodeSigParams struct and insert_code_signature_command_into_buffer() as shared helper for inserting LC_CODE_SIGNATURE into header padding - Update generate_adhoc_signature() to parse binary context for endianness - Update adhoc_sign() to detect missing LC_CODE_SIGNATURE and insert it - Update adhoc_sign_file() to use shared helper for LC_CODE_SIGNATURE insertion - Add test_sign_unsigned_binary test case
nichmor
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for ad-hoc signing Mach-O binaries that don't have an existing
LC_CODE_SIGNATUREload command (unsigned binaries).Changes:
write_u32/write_u64helpers that respect binary endianness (ctx.le) instead of hardcoded.to_le_bytes()InsertCodeSigParamsstruct andinsert_code_signature_command_into_buffer()as shared helper for insertingLC_CODE_SIGNATUREinto header paddinggenerate_adhoc_signature()to parse binary context for endiannessadhoc_sign()to detect missingLC_CODE_SIGNATUREand insert itadhoc_sign_file()to use shared helper forLC_CODE_SIGNATUREinsertionThis is for PyO3/maturin#3114 (https://github.com/PyO3/maturin/actions/runs/23901410353/job/69698993401)