Skip to content

bugfix - image wont show when using local activestorage#77

Open
mirzalazuardi wants to merge 1 commit intonickjj:mainfrom
mirzalazuardi:bugfix_broken_image_using_activestorage_local
Open

bugfix - image wont show when using local activestorage#77
mirzalazuardi wants to merge 1 commit intonickjj:mainfrom
mirzalazuardi:bugfix_broken_image_using_activestorage_local

Conversation

@mirzalazuardi
Copy link
Copy Markdown

@mirzalazuardi mirzalazuardi commented Mar 30, 2024

Hi @nickjj,

I found the issue when i using activestorage with disk service, and got me errors when i check on the image url.
The image also wont show on the web. But i already found a solution for this. which is to add some dependencies.
Please check my PR

Thanks

@mirzalazuardi mirzalazuardi changed the title bugfix image wont show when using local activestorage bugfix - image wont show when using local activestorage Mar 30, 2024
@nickjj
Copy link
Copy Markdown
Owner

nickjj commented Mar 30, 2024

Hi,

Yep, ActiveStorage requires system level dependencies and libvips is the way to go. I've added that package to my own personal projects that use it.

The concern here is not everyone uses ActiveStorage and including libvips increases the Docker image size. If we wanted to make ActiveStorage work out of the box for this example project it would require also adding new JavaScript dependencies for direct upload support and modifying the app JS code to include it.

Maybe we can keep this PR open to see if others are interested in having ActiveStorage be included by default. If there's demand for that, I'd be happy to add it.

@mirzalazuardi
Copy link
Copy Markdown
Author

Thanks... happy to help & contribute to your project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants