paybox_hidden_fields helper trouble#4
Open
nicolasGuillouet wants to merge 2 commits intonicolasblanco:masterfrom
Open
paybox_hidden_fields helper trouble#4nicolasGuillouet wants to merge 2 commits intonicolasblanco:masterfrom
nicolasGuillouet wants to merge 2 commits intonicolasblanco:masterfrom
Conversation
…nctionnals test and using own keys pair.
|
+1, This is very important, without it, the gem is useless now ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I wrote here : #2, the rails helper method escape strings values. If these values contains special chars, the HMAC returned by hash_form_fields_from is not calculated on same values.
We could prefer to change hash_form_fields_from and make an escape on each value, but I am afraid i could change the 'PBX_RETOUR' and other fields needed :-(
Nicolas