Use staticfiles finders for fetch_resources #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
N.B. staticfiles finders are currently a "private interface," but given that the task here is to resolve static file URLs into absolute paths, this seems like a very appropriate use. https://docs.djangoproject.com/en/1.6/ref/settings/#staticfiles-finders |
Owner
|
Thanks for pointing this out. This makes a lot of sense in case collected static files are not available on the app server. I still consider if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my app, the existing implementation of fetch_resources only worked if collectstatic had been run. Using Django's staticfiles.finders.find() is more flexible for different staticfiles configurations.