Bug fix? I think @function always leads to "new " in usage#93
Open
yaacovCR wants to merge 2 commits intonikhilmodak:masterfrom
yaacovCR:master
Open
Bug fix? I think @function always leads to "new " in usage#93yaacovCR wants to merge 2 commits intonikhilmodak:masterfrom yaacovCR:master
yaacovCR wants to merge 2 commits intonikhilmodak:masterfrom
yaacovCR:master
Conversation
A la grunt-ngdocs m7r/grunt-ngdocs@c985bc6d
grunt-ngdocs likely has identical bug, secondary to constructor property on prototype and truthy versus truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took these lines from grunt-ngdocs, but I imagine it is broken there... Doc.constructor test always returned true, likely secondary to constructor property on prototype and truthy versus truth.