feat: MSVC auto-detection + C compiler check before torch.compile#210
Merged
nikopueringer merged 1 commit intonikopueringer:mainfrom Mar 31, 2026
Merged
Conversation
torch.compile needs a C compiler (cl.exe on Windows, gcc on Linux). On Windows, Visual Studio Build Tools installs cl.exe but doesn't add it to PATH — users get a cryptic compilation failure and fall back to eager mode (~30% slower) without knowing why. - Auto-detect MSVC in standard Visual Studio install locations - Check for C compiler before attempting compile - Show actionable message with install link if missing - Skip reasons are logged clearly instead of generic "compilation failed"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC auto-detection + C compiler check before torch.compile
torch.compileneeds a C compiler (cl.exe on Windows, gcc on Linux). On Windows, Visual Studio Build Tools installs cl.exe but doesn't add it to PATH — users get a cryptic compilation failure and fall back to eager mode (~30% slower) without knowing why.What does this change?
Replaces the simple
skip_compileboolean with a prerequisite check that:Only touches
CorridorKeyModule/inference_engine.py. No new dependencies.How was it tested?
Checklist
uv run pytestpassesuv run ruff checkpassesuv run ruff format --checkpasses