fix: handle file and document open events for external URLs#5
Merged
Conversation
Add support for opening HTML files from Finder and terminal, and support URLs opened via terminal (e.g., from Vite bundle analyzer). Changes: - Implement application(_:open:) to handle file open events (kAEOpenDocuments) - Move early initialization to applicationWillFinishLaunching to ensure engine and source tracking are ready before any events arrive - Ensures URLs opened at cold launch preserve source app context for source-based routing rules Fixes URLs from terminal tools like `open /path/to/file.html` and Finder double-click opens now correctly route to configured browsers instead of silently failing. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes file opening and external URL routing by implementing support for document open events and ensuring proper initialization order on cold launch.
Problem
Opening HTML files from Finder or terminal (e.g.,
open /path/to/file.htmlfrom Vite bundle analyzer) would activate the app but silently fail to route the file. The app only handled URL scheme events (http/https) but not file open events.Solution
application(_:open:)to handle document open events (kAEOpenDocuments)applicationWillFinishLaunchingto ensure engine and source tracking are ready before any events arriveTesting
🤖 Generated with Claude Code