Skip to content

fix: remove unsafe exec() in AIRoadmapChat.tsx #9881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

fix: remove unsafe exec() in AIRoadmapChat.tsx #9881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/lib/markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// @ts-ignore
import MarkdownIt from 'markdown-it';
import MarkdownItAsync from 'markdown-it-async';
import sanitizeHtml from 'sanitize-html';

// replaces @variableName@ with the value of the variable
export function replaceVariables(
Expand Down Expand Up @@ -87,7 +88,15 @@ export async function markdownToHtmlWithHighlighting(markdown: string) {
return defaultRender(tokens, idx, options, env, self);
};

return markdownItAsync.renderAsync(replaceVariables(markdown));
const rawHtml = await markdownItAsync.renderAsync(replaceVariables(markdown));
return sanitizeHtml(rawHtml, {
allowedTags: sanitizeHtml.defaults.allowedTags.concat(['span', 'img']),
allowedAttributes: {
...sanitizeHtml.defaults.allowedAttributes,
'*': ['class', 'style'],
a: ['href', 'name', 'target', 'rel'],
},
});

} catch (e) {
return markdown;
Expand Down