Skip to content

refactor: move hash_to_object method where it should belong #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thde merged 1 commit into from
Jun 2, 2025
Merged

refactor: move hash_to_object method where it should belong #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions lib/netbox_client_ruby/communication.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,8 @@ def connection
NetboxClientRuby::Connection.new
end

def hash_to_object(hash)
objectified_class = Class.new
objectified_instance = objectified_class.new
hash.each do |k, v|
variable_name = sanitize_variable_name(k)
variable_name = "_#{variable_name}" if objectified_instance.methods.map(&:to_s).include?(variable_name)

objectified_instance.instance_variable_set(:"@#{variable_name}", v)
objectified_class.send(:define_method, variable_name, proc { instance_variable_get(:"@#{variable_name}") })
end
objectified_instance
end

private

def sanitize_variable_name(raw_name)
raw_name.gsub(/[^a-zA-Z0-9_]/, '_')
end

def read(response)
response.body
end
Expand Down
17 changes: 17 additions & 0 deletions lib/netbox_client_ruby/entity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,23 @@ def object_fields
self.class.object_fields
end

def hash_to_object(hash)
objectified_class = Class.new
objectified_instance = objectified_class.new
hash.each do |k, v|
variable_name = sanitize_variable_name(k)
variable_name = "_#{variable_name}" if objectified_instance.methods.map(&:to_s).include?(variable_name)

objectified_instance.instance_variable_set(:"@#{variable_name}", v)
objectified_class.send(:define_method, variable_name, proc { instance_variable_get(:"@#{variable_name}") })
end
objectified_instance
end

def sanitize_variable_name(raw_name)
raw_name.gsub(/[^a-zA-Z0-9_]/, '_')
end

def data_to_obj(raw_data, klass_or_proc = nil)
if klass_or_proc.nil?
hash_to_object raw_data
Expand Down