Skip to content

Code review for final project#9

Open
chris19960730 wants to merge 7 commits intoningowo:mainfrom
chris19960730:codeReviewForFinalProject
Open

Code review for final project#9
chris19960730 wants to merge 7 commits intoningowo:mainfrom
chris19960730:codeReviewForFinalProject

Conversation

@chris19960730
Copy link

🏆

Please double check all the meta info in your package.json file to make it consistent with your project
Please change all the var to cons to meet ES6 standard
Just a reminder, please don't expose the credential since anyone can access your database with that url
It looks unnecessary to have both NavUser.js and NavBar.js, please consider refactor those two files to make the code clean. A simple way to do is you can either move the entire NavUser logic into the NavBar.js or move line 7 to line 35 to the NavUser.js file
Looks like line 79-81 are used in several files, a better solution is to refactor it into a component for a clean coding style
It would be better that each module has its own CSS file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant