Skip to content

make http header parsing case insensitive #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make http header parsing case insensitive #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddd349d
make http header parsing case insensitive
jonasBoss Jul 28, 2025
0a1c608
fixup
jonasBoss Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ pub fn read_http_header<'a>(
let mut sec_websocket_key = String::new();

for (name, value) in headers {
match name {
match_ascii_case_insensitive!{ name,
"Upgrade" => is_websocket_request = str::from_utf8(value)? == "websocket",
"Sec-WebSocket-Protocol" => {
// extract a csv list of supported sub protocols
Expand All @@ -58,11 +58,11 @@ pub fn read_http_header<'a>(
.unwrap();
}
}
}
},
"Sec-WebSocket-Key" => {
sec_websocket_key = String::from(str::from_utf8(value)?);
}
&_ => {
},
_ => {
// ignore all other headers
}
}
Expand All @@ -78,6 +78,14 @@ pub fn read_http_header<'a>(
}
}

macro_rules! match_ascii_case_insensitive {
($m:expr, $($case:literal => $do:expr),+ , _ => $default:expr) => {
if false {}
$(else if $m.eq_ignore_ascii_case($case) { $do })+
else {$default}
};
}

pub fn read_server_connect_handshake_response(
sec_websocket_key: &WebSocketKey,
from: &[u8],
Expand Down