Skip to content

fix: pin onboarding action buttons on small screens#7

Merged
ninocss merged 2 commits intomainfrom
copilot/fix-onboarding-buttons-display
Apr 11, 2026
Merged

fix: pin onboarding action buttons on small screens#7
ninocss merged 2 commits intomainfrom
copilot/fix-onboarding-buttons-display

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

On small screens, primary action buttons (Next, Login, Skip, Finish) in the onboarding flow were cut off because they lived at the bottom of content columns that could overflow without scrolling.

Approach

Introduced an optional footer parameter on _StepWrapper that renders outside and below the scrollable content area, always visible regardless of screen height.

class _StepWrapper extends StatelessWidget {
  final Widget content;  // now wrapped in Expanded — scrollable
  final Widget? footer;  // pinned below, always visible
  ...
  // In build():
  Expanded(child: content),
  if (footer != null) ...[
    const SizedBox(height: 12),
    footer!,
  ],
}

Per-step changes

  • Language — language list scrollable; Next button → footer
  • Theme/Appearance — removed LayoutBuilder/ConstrainedBox wrapper; settings list scrollable; Next button → footer
  • Login (search mode) — school list retains Expanded; manual entry + demo mode buttons → footer
  • Login (manual/filled mode) — form fields only in SingleChildScrollView; login + demo mode buttons → footer
  • Gemini — info box + API key field scrollable; Skip/Next row → footer
  • Tutorial/Finish — feature list scrollable; Finish button → footer

Copilot AI and others added 2 commits April 11, 2026 12:45
…crollable on small screens

Agent-Logs-Url: https://github.com/ninocss/UntisPlus/sessions/19c7b24f-6a11-4d84-b889-6050ed14e937

Co-authored-by: ninocss <108231535+ninocss@users.noreply.github.com>
@ninocss ninocss marked this pull request as ready for review April 11, 2026 12:47
Copilot AI review requested due to automatic review settings April 11, 2026 12:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes onboarding flow action buttons being cut off on small screens by restructuring step layouts so the main content can scroll while primary actions remain pinned and always visible.

Changes:

  • Added an optional footer to _StepWrapper and rendered it below the scrollable content.
  • Updated onboarding steps (Language, Appearance, Login, Gemini, Tutorial/Finish) to move primary action buttons into the pinned footer area.
  • Wrapped step content in SingleChildScrollView where appropriate to prevent overflow on short viewports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ninocss ninocss merged commit b436832 into main Apr 11, 2026
6 checks passed
@ninocss ninocss deleted the copilot/fix-onboarding-buttons-display branch April 11, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants