Fix #52. Fix issues with copying layers when joining 1d sequences.#53
Merged
cmeyer merged 1 commit intonion-software:masterfrom Aug 18, 2025
Merged
Conversation
Tiomat85
reviewed
Jul 25, 2025
Contributor
Tiomat85
left a comment
Tiomat85
left a comment
There was a problem hiding this comment.
Just one question that I am not sure of.
| for display_layer in display_layers: | ||
| result_display_item.append_display_layer(display_layer) | ||
| if display_layers_list: | ||
| result_display_item.display_layers_list = display_layers_list |
Contributor
There was a problem hiding this comment.
Would this need to be a deepcopy?
Contributor
Author
There was a problem hiding this comment.
Nope. display_layers_list is a convenience function for copying display layer properties and doesn't store the new value directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52.
Adds test.