Move the StaleStreamException to the general Stream package.#36
Closed
Tiomat85 wants to merge 1 commit intonion-software:masterfrom
Closed
Move the StaleStreamException to the general Stream package.#36Tiomat85 wants to merge 1 commit intonion-software:masterfrom
Tiomat85 wants to merge 1 commit intonion-software:masterfrom
Conversation
cmeyer
reviewed
Aug 5, 2025
Collaborator
cmeyer
left a comment
cmeyer
left a comment
There was a problem hiding this comment.
I'm not convinced this is the right place for this. Is there a reason this needs to be shared outside of instrumentation-kit?
Author
|
Technically no, it could be rolled into stem_controller.py or something instead. My thought was that it is a pretty generic exception relating to a stream having out of date data, not directly limited to a REST based stream, so the natural place that came to mind was in the file where the streams were defined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.