Add filetime to datetime conversion#41
Closed
MattRoyle wants to merge 7 commits intonion-software:masterfrom
Closed
Add filetime to datetime conversion#41MattRoyle wants to merge 7 commits intonion-software:masterfrom
MattRoyle wants to merge 7 commits intonion-software:masterfrom
Conversation
cmeyer
requested changes
Jan 29, 2026
Collaborator
cmeyer
left a comment
cmeyer
left a comment
There was a problem hiding this comment.
Overall looks good. Need to get the tests to pass. I'd prefer not adding dependencies to test-requirements.txt if possible.
Collaborator
|
Also, I didn't see this was draft - so I jumped the gun a bit - but comments still hold. Let me know if you can't work it out. |
…standard form, removed dependency on timezone library/ tzdata issue
cmeyer
approved these changes
Jan 29, 2026
Collaborator
cmeyer
left a comment
cmeyer
left a comment
There was a problem hiding this comment.
This looks good other than a few nit-picks. If this is ready to be merged, change it from Draft to not-Draft and I'll merge it. I can fix the comments when I merge it.
Collaborator
|
Squashed and merged with minor formatting edits: c98dbd8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds conversions between a datetime and a windows filetime #40