scriptcomp: Don't generate dead MOVSP instructions when returning [WIP]#89
Open
mtijanic wants to merge 1 commit intoniv:masterfrom
Open
scriptcomp: Don't generate dead MOVSP instructions when returning [WIP]#89mtijanic wants to merge 1 commit intoniv:masterfrom
mtijanic wants to merge 1 commit intoniv:masterfrom
Conversation
1 task
mtijanic
added a commit
that referenced
this pull request
Jul 22, 2023
Compiler is generating dead MOVSP instructions in some cases when returning from a function, and merging a live one with a dead one causes issues, unsurprisingly. So, disabling merging until #89 is implemented properly. ## Testing Added a test case that fails at TOT but passes with this change ## Changelog ### Fixed - Fixed STACK_UNDERFLOW errors when compiling with `-O2` ## Licence - [x] I am licencing my change under the project's MIT licence, including all changes to GPL-3.0 licenced parts of the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why this was disabled originally. Needs more testing before merging, leaving here as a WIP so others can test too.
Testing
Test suite, plus disassembly. More tests TBD.
Changelog
Fixed
Licence