fix: forward nvidiaHash for nixgl.auto derivation too#175
Open
muggenhor wants to merge 2 commits intonix-community:mainfrom
Open
fix: forward nvidiaHash for nixgl.auto derivation too#175muggenhor wants to merge 2 commits intonix-community:mainfrom
muggenhor wants to merge 2 commits intonix-community:mainfrom
Conversation
This allows separating the *use* of nixgl.auto.nixGLDefault from the location where we pass nvidiaHash to provide a pure instantiation.
Instead of duplicating its definition, because that leaves the possibility for bugs when these duplicates aren't in sync.
muggenhor
force-pushed
the
fix/fwd-nvidia-hash-to-auto
branch
from
f3f040c to
12f8b90
Compare
|
nix still builds impure-nvidia-version-file when I just use inputs.nixgl.packages.${pkgs.stdenv.hostPlatform.system}.nixGLDefault Is it because nix needs to build impure-nvidia-version-file to know the value of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows separating the use of nixgl.auto.nixGLDefault from the
location where we pass nvidiaHash to provide a pure instantiation.
Without this usage of
nixgl.auto.XXXis always impure.Also reuse
nixgl.autointopwhen nVidia is forced instead ofduplicating its definition, because that leaves the possibility for
bugs when these duplicates aren't in sync.