This repository was archived by the owner on Jan 25, 2024. It is now read-only.
fix attrset merging for >= 3 instances #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphorien
force-pushed
the
merge3
branch
2 times, most recently
from
ec0f8a0 to
b971524
Compare
aaronjanse
suggested changes
Jul 27, 2022
Member
aaronjanse
left a comment
aaronjanse
left a comment
There was a problem hiding this comment.
Thanks for the PR @symphorien! I left a few comments
Comment on lines
+299
to
+306
| #[test] | ||
| fn attrs_merge_3() { | ||
| let code = "{ a.b = 1; a.c = 2; a.d = 3; }".to_string(); | ||
| assert_eq!(eval(&format!("{}.a.b", code)).as_int().unwrap(), 1); | ||
| assert_eq!(eval(&format!("{}.a.c", code)).as_int().unwrap(), 2); | ||
| assert_eq!(eval(&format!("{}.a.d", code)).as_int().unwrap(), 3); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Thank you for adding a test!
Contributor
Author
|
ping @aaronjanse |
Member
|
LGTM. Thanks @symphorien! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Before:
this happens for >= 3 instances of a
Further context