Introduce KNYC Data Provider

[alexgoldschmidt]

Moved NCDC specific functionality into separate file
Added KNYC weather data provider

Combine data from NCDC and KNYC for final determination

[njason]

I was having trouble running this. It turns out the issue was the folder DataProviders and Models needed to be lower case to match the package name. I did get it running but am seeing a gap in days from the output (missing 6/24)

jason@wargo:~/code/shouldwater$ go run main.go USW00094728
Done loading config.
StationId:  USW00094728
Start NCDC Data
[{2022-06-21 00:00:00 +0000 UTC 0.06} {2022-06-22 00:00:00 +0000 UTC 0.02} {2022-06-23 00:00:00 +0000 UTC 0.08}]
Start KNYC Data
Start Reading Data
Done Reading Data
[{2022-06-26 00:00:00 +0000 UTC 0} {2022-06-25 00:00:00 +0000 UTC 0} {2022-06-28 00:00:00 +0000 UTC 0} {2022-06-27 00:00:00 +0000 UTC 0.8}]
It's rained 0.96 inches in the last week
You should water the trees.

One issue is that the NCDC data isn't consistent, it sometimes is over a week behind. Also, I was looking for a solution that can work in any area, not just in NYC.

Usually I don't like to resort to web scrapping until absolutely necessary. I would prefer to use some sort of web service list a REST API but also don't want to have to pay for a license to use the API or keep the program constantly running to capture the data. Apparently this is a very small or impossible target to hit. Of the APIs I sent you, I tried tomorrow.io, AccuWeather, and AerisWeather and they all are not able to give you 7 days of historical data without purchasing a license.

[njason]

I'm not sure if this is the proper way to calculate the rainfall, wouldnt these values overlap in time?

[alexgoldschmidt]

Yeah, the best data looks like it's all behind paywalls. I figured if we can't get all 7 days from the same source we could try aggregating data from a few sources and try building up a full week that way. I wasn't actually sure what the data meant by Last Hour, Last 3 Hours, Last 6 hours. There was only ever one field filled out in the table, so I figured it was just collected at different granularities but not overlapping.

…

On Tue, Jun 28, 2022, 11:47 PM Jason Biegel ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In DataProviders/knycProvider.go <#1 (comment)>: > + +func GetKNYCRainfall() []models.RainfallDate { + + knycData := getKNYCData() + + var knycRainfall [7]models.RainfallDate + dayCounter := 0 + dailyRainfallMap := make(map[string]float64) + for _,knycRow := range knycData.Data { + + year, month, _ := time.Now().Date() + rowDate := fmt.Sprintf("%4d-%02d-%02sT00:00:00", year, month, knycRow.Date) + + dailyRainfallMap[rowDate] += knycRow.Precipitation.LastHour + dailyRainfallMap[rowDate] += knycRow.Precipitation.Last3Hours + dailyRainfallMap[rowDate] += knycRow.Precipitation.Last6Hours I'm not sure if this is the proper way to calculate the rainfall, wouldnt these values overlap in time? — Reply to this email directly, view it on GitHub <#1 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH6CSNSCJILZM7JPY77ZAOLVRPBLJANCNFSM5Z3HCVPQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>