Extract parsing of response data to their own functions#27
Open
bvisness wants to merge 9 commits intonjern:masterfrom
Open
Extract parsing of response data to their own functions#27bvisness wants to merge 9 commits intonjern:masterfrom
bvisness wants to merge 9 commits intonjern:masterfrom
Conversation
Now produces a zero time instead of exploding
* Handle more stupid timestamp formats * Add another format string * Add one more test case
adding a custom connection error and debug tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found that we wanted to use parts of this library without being forced to use the provided delivery handler. This PR simply extracts the request-decoding parts of the process to their own functions. This should be completely backwards-compatible.
cc @Dave-Dohmeier