refactor: use slices.Equal to simplify code#995
Open
tsinghuacoder wants to merge 1 commit intonknorg:masterfrom
Open
refactor: use slices.Equal to simplify code#995tsinghuacoder wants to merge 1 commit intonknorg:masterfrom
tsinghuacoder wants to merge 1 commit intonknorg:masterfrom
Conversation
Signed-off-by: tsinghuacoder <tsinghuacoder@icloud.com>
Member
|
Thanks for the contribution! As you can see in https://github.com/nknorg/nkn/blob/master/go.mod, nkn requires go 1.20 to build, but slices was introduced in go 1.21. But moving to go 1.21 is just a matter of time, so maybe we can keep this PR open for now, and merge it when we move to go 1.21. |
Author
Thank you for your reply. The currently stable version of Go is 1.24. If needed, I would be happy to open a new PR to upgrade it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.