Skip to content

refactor: use slices.Equal to simplify code#995

Open
tsinghuacoder wants to merge 1 commit intonknorg:masterfrom
tsinghuacoder:master
Open

refactor: use slices.Equal to simplify code#995
tsinghuacoder wants to merge 1 commit intonknorg:masterfrom
tsinghuacoder:master

Conversation

@tsinghuacoder
Copy link

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Signed-off-by: tsinghuacoder <tsinghuacoder@icloud.com>
@yilunzhang
Copy link
Member

Thanks for the contribution!

As you can see in https://github.com/nknorg/nkn/blob/master/go.mod, nkn requires go 1.20 to build, but slices was introduced in go 1.21.

But moving to go 1.21 is just a matter of time, so maybe we can keep this PR open for now, and merge it when we move to go 1.21.

@tsinghuacoder
Copy link
Author

Thanks for the contribution!

As you can see in https://github.com/nknorg/nkn/blob/master/go.mod, nkn requires go 1.20 to build, but slices was introduced in go 1.21.

But moving to go 1.21 is just a matter of time, so maybe we can keep this PR open for now, and merge it when we move to go 1.21.

Thank you for your reply. The currently stable version of Go is 1.24. If needed, I would be happy to open a new PR to upgrade it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants