ci: add catalog api contract drift check

[lukyrys]

Summary

• integrate the remaining catalog API hardening branch without plan docs or pycache artifacts
• remove the in-repo catalog-api service after extraction to wdc-catalog-api
• add a pinned OpenAPI contract drift check for CatalogClient

Verification

• CATALOG_API_VERSION=0.2.0 node scripts/check-catalog-drift.mjs
• git diff --check

[coderabbitai]

Warning

Rate limit exceeded

@lukyrys has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 27 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee3090b4-723d-4814-a472-448d053385e5

📥 Commits

Reviewing files that changed from the base of the PR and between e4de493 and 414a701.

📒 Files selected for processing (42)

• .github/workflows/catalog-contract.yml
• scripts/check-catalog-drift.mjs
• services/catalog-api-MOVED.md
• services/catalog-api/.dockerignore
• services/catalog-api/.gitignore
• services/catalog-api/Dockerfile
• services/catalog-api/README.md
• services/catalog-api/app/__init__.py
• services/catalog-api/app/auth.py
• services/catalog-api/app/catalog.py
• services/catalog-api/app/data/apps/apache.json
• services/catalog-api/app/data/apps/caddy.json
• services/catalog-api/app/data/apps/cloudflared.json
• services/catalog-api/app/data/apps/mailpit.json
• services/catalog-api/app/data/apps/mariadb.json
• services/catalog-api/app/data/apps/mkcert.json
• services/catalog-api/app/data/apps/mysql.json
• services/catalog-api/app/data/apps/nginx.json
• services/catalog-api/app/data/apps/php.json
• services/catalog-api/app/data/apps/redis.json
• services/catalog-api/app/db.py
• services/catalog-api/app/devices.py
• services/catalog-api/app/generators.py
• services/catalog-api/app/main.py
• services/catalog-api/app/schemas.py
• services/catalog-api/app/service.py
• services/catalog-api/app/static/admin.css
• services/catalog-api/app/templates/app_detail.html
• services/catalog-api/app/templates/app_form.html
• services/catalog-api/app/templates/apps_list.html
• services/catalog-api/app/templates/base.html
• services/catalog-api/app/templates/login.html
• services/catalog-api/docker-compose.yml
• services/catalog-api/pyproject.toml
• services/catalog-api/requirements.txt
• services/catalog-api/run.cmd
• services/catalog-api/tests/conftest.py
• services/catalog-api/tests/test_auth.py
• services/catalog-api/tests/test_devices.py
• services/catalog-api/tests/test_generators.py
• services/catalog-api/tests/test_service.py
• services/catalog-api/tests/test_smoke.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch integrate-catalog-api-hardening-clean

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 414a701e4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Add sync-exists endpoint to drift guard

The drift check omits "/api/v1/sync/config/{device_id}/exists" from REQUIRED_PATHS, even though the daemon calls that contract in Program.cs (/api/sync/exists proxy). If the catalog API drops or renames only that endpoint, this CI check will still pass and the sync-exists flow will regress at runtime without early detection.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Validate catalog DTO schemas instead of unrelated ones

This schema map does not include the catalog document types consumed by CatalogClient (CatalogDocument, AppDoc, ReleaseDoc, DownloadDoc fields like apps, releases, downloads, url, etc.), so breaking changes to the binary catalog payload can pass this check and only fail in production when RefreshAsync deserializes. The current entries focus on auth/sync DTOs and miss the primary contract this workflow claims to protect.

Useful? React with 👍 / 👎.