Fix stale documentation in dop853.h after thread-safe refactoring#995
Merged
mattfidler merged 2 commits intoparallel-updatesfrom Mar 17, 2026
Merged
Fix stale documentation in dop853.h after thread-safe refactoring#995mattfidler merged 2 commits intoparallel-updatesfrom
mattfidler merged 2 commits intoparallel-updatesfrom
Conversation
- Update contd8() signature from 2 to 3 arguments (ctx, i, s) - Replace deleted accessor functions (xRead, hRead, etc.) with equivalent dop853_ctx_t struct field documentation - Update "Remarks about C version" to mention context struct - Fix typo: 'stff' -> 'stiff' Co-authored-by: mattfidler <514778+mattfidler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on making rxode2 more thread safe
Fix stale documentation in dop853.h after thread-safe refactoring
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dop853.hdocumentation was never updated after the thread-safe refactoring that replaced file-scope statics and accessor functions withdop853_ctx_t. The comment block still referenced deleted functions and the oldcontd8signature.Changes
contd8signature: Updated fromcontd8(i, s)tocontd8(ctx, i, s)with description of thectxparameterxRead/hRead/nstepRead/naccptRead/nrejctRead/nfcnReadfunction list with equivalentdop853_ctx_tstruct field references (ctx->xout,ctx->hout,ctx->nstep, etc.)x=xRead()reference tox=ctx->xoutdop853_ctx_tcontext struct for thread-safe reentrant usage"stff→stiff🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.