Skip to content

Add .github/copilot-instructions.md for Copilot coding agent#998

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/set-up-copilot-instructions
Draft

Add .github/copilot-instructions.md for Copilot coding agent#998
Copilot wants to merge 2 commits intomainfrom
copilot/set-up-copilot-instructions

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026

Adds repository-wide instructions for the GitHub Copilot coding agent, as recommended in the Copilot coding agent best practices.

Changes

  • .github/copilot-instructions.md — new file covering:
    • Project overview (mixed R/C/C++/Fortran ODE pharmacometric package)
    • Build, test, and documentation commands (including the NOT_CRAN=true requirement for non-CRAN tests)
    • ODE solving pipeline and key subsystem descriptions
    • Important file map (grammar, codegen, solvers, UI layer, event table)
    • Files that must not be edited manually (generated artifacts)
    • R naming conventions (camelCase, .dotPrefix) and C/C++ conventions (Rf_error wrapping, header defines, OpenMP guards)

Content mirrors the existing CLAUDE.md to keep both agent instruction files consistent.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • gh.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>✨ Set up Copilot instructions</issue_title>
<issue_description>Configure instructions for this repository as documented in Best practices for Copilot coding agent in your repository.

</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: mattfidler <514778+mattfidler@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Copilot instructions for repository Add .github/copilot-instructions.md for Copilot coding agent Mar 17, 2026
Copilot AI requested a review from mattfidler March 17, 2026 05:14
**Event Table** (`src/et.cpp`, `src/etTran.cpp`, `R/et.R`):
- `et()` constructs dosing/sampling event tables
- `etTran()` transforms event tables for the internal solver format
- Supports NONMEM-compatible event IDs (evid 0–4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it support the full range of nlmixr2 EVIDs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does 😄 . AI tends to hallucinate towards NONMEM.

Copy link
Member

@mattfidler mattfidler Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I removed the VODE code years ago (since it wasn't being used or integrated yet), and it still thinks it is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Set up Copilot instructions

3 participants