Change VerifiablePresentation to TokenContentVerifiablePresentation#993
Merged
Milena-Czierlinski merged 7 commits intorelease/openid4vcfrom Mar 12, 2026
Merged
Conversation
Milena-Czierlinski
changed the title
tnotheis
requested changes
Mar 12, 2026
Member
tnotheis
left a comment
tnotheis
left a comment
There was a problem hiding this comment.
Can you explain why this change is necessary?
packages/content/src/tokens/TokenContentVerifiablePresentation.ts
Outdated
Show resolved
Hide resolved
Magnus-Kuhn
previously approved these changes
Mar 12, 2026
Magnus-Kuhn
previously approved these changes
Mar 12, 2026
Contributor
|
tbh I don't know what the best practices are regarding those imports 😃 |
Milena-Czierlinski
added
enhancement
Member
Author
|
Typically we put as much as possible into the barrel files (index.js) if it is needed in other files outside of the respective directory. We have to check that we don't introduce circular dependencies by doing so. But I think I didn't. |
tnotheis
approved these changes
Mar 12, 2026
Magnus-Kuhn
pushed a commit
that referenced
this pull request
Mar 27, 2026
…993) * refactor: make VerifiablePresentation to TokenContentVerifiablePresentation * test: adjust expected type of token content * test: app-runtime test * chore: re-add TokenContentVerifiablePresentation * chore: type * refactor: add ProprietaryAttributeValue to barrel file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
We noticed in the app that it is strange to have VerifiablePresentation in the AttributeValues, since it is not an attribute. Instead, it should be used as content in the token. We already have a special token content called TokenContentDeviceSharedSecret. Accordingly, it makes sense for us to have a TokenContentVerifiablePresentation as well.