Skip to content

Use AttributeIdString as type for attributeId in requests #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Milena-Czierlinski merged 1 commit into from
Mar 13, 2026
Merged

Use AttributeIdString as type for attributeId in requests #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/runtime/src/useCases/common/Schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17317,13 +17317,17 @@ export const AcceptAuthorizationRequestRequest: any = {
"type": "object"
},
"attributeId": {
"type": "string"
"$ref": "#/definitions/AttributeIdString"
}
},
"required": [
"attributeId",
"authorizationRequest"
]
},
"AttributeIdString": {
"type": "string",
"pattern": "ATT[A-Za-z0-9]{17}"
}
}
}
Expand All @@ -17336,7 +17340,7 @@ export const CreatePresentationTokenRequest: any = {
"type": "object",
"properties": {
"attributeId": {
"type": "string"
"$ref": "#/definitions/AttributeIdString"
},
"expiresAt": {
"$ref": "#/definitions/ISO8601DateTimeString"
Expand All @@ -17352,6 +17356,10 @@ export const CreatePresentationTokenRequest: any = {
],
"additionalProperties": false
},
"AttributeIdString": {
"type": "string",
"pattern": "ATT[A-Za-z0-9]{17}"
},
"ISO8601DateTimeString": {
"type": "string",
"errorMessage": "must match ISO8601 datetime format",
Expand Down
4 changes: 2 additions & 2 deletions packages/runtime/src/useCases/consumption/openid4vc/AcceptAuthorizationRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import { Result } from "@js-soft/ts-utils";
import { AttributesController, LocalAttribute, OpenId4VcController, OwnIdentityAttribute } from "@nmshd/consumption";
import { CoreId } from "@nmshd/core-types";
import { Inject } from "@nmshd/typescript-ioc";
import { RuntimeErrors, SchemaRepository, SchemaValidator, UseCase } from "../../common";
import { AttributeIdString, RuntimeErrors, SchemaRepository, SchemaValidator, UseCase } from "../../common";

export interface AbstractAcceptAuthorizationRequestRequest<T> {
authorizationRequest: T;
attributeId: string;
attributeId: AttributeIdString;
}

export interface AcceptAuthorizationRequestRequest extends AbstractAcceptAuthorizationRequestRequest<OpenId4VpResolvedAuthorizationRequest> {}
Expand Down
4 changes: 2 additions & 2 deletions packages/runtime/src/useCases/consumption/openid4vc/CreatePresentationToken.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import { CoreDate, CoreId } from "@nmshd/core-types";
import { TokenDTO } from "@nmshd/runtime-types";
import { TokenController } from "@nmshd/transport";
import { Inject } from "@nmshd/typescript-ioc";
import { ISO8601DateTimeString, RuntimeErrors, SchemaRepository, SchemaValidator, UseCase } from "../../common";
import { AttributeIdString, ISO8601DateTimeString, RuntimeErrors, SchemaRepository, SchemaValidator, UseCase } from "../../common";
import { TokenMapper } from "../../transport/tokens/TokenMapper";

export interface CreatePresentationTokenRequest {
attributeId: string;
attributeId: AttributeIdString;
expiresAt: ISO8601DateTimeString;
ephemeral: boolean;
}
Expand Down
Loading