Open
Conversation
|
LGTM 👍 (would have positively reviewed if I had the rights) |
Owner
|
Thanks for the PR. I don't have a MacOS setup to test this. However, looking at the code, I'm not sure if the code works as intended. When there's multiple authorizations in that XML file, each one of them can have their own username or authorization method. Your code seems to account for multiple authorizations to be present, but I'm not sure whether the key names / authorization methods will be correctly matched to each key since it's still just using tree.find on the whole XML tree? Can you check that again to make sure the method and username are correct when there's multiple different ones? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is better viewed with whitespace ignored.
Summary
This PR adds support for multiple Adobe Digital Editions decryption keys on MacOS. I found myself with two decryption keys because I:
I believe this issue is describing the same problem I had.
Testing
This can be tested by adding a new
<adept:credentials>block to your~/Library/Application Support/Adobe/Digital Editions/activation.dat. I do not know how to generate those keys, however.Let me know if I can do anything else to make this better or to make testing it easier!