adapting the code to new api #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Noah,
I installed noms using pip for some personal use to find that it wasn't working. Started looking on the issues and came to know that it was because of the change in api. They have totally changed various attributes. I have made changes to the code to adapt to the new api keeping your code as much as possible untouched.
One of the issues I had was nutrient_dict being imported in various modules as a global variable. So I have made nutrient_dict as class.
I have tested the package with test file you provided. It works.
Would you please kindly look into this pull request and take necessary action?
Thanks a lot for your time and your wonderful work,
Best regards,
-Jithesh