feat(assistant-panel): add tool use / function calling#360
feat(assistant-panel): add tool use / function calling#360not-reed wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
not-reed
commented
Mar 12, 2026
not-reed
commented
- Plugin-style tool discovery: tools//spec.json + run executable
- OpenAI and Gemini tool_calls integration with multi-turn loop
- Confirmation system with allowlist (approve once, always allow, deny)
- Generic tool:qualifier pattern for granular permissions (e.g. shell:ls)
- Quote-aware shell tokenizer for safe compound command approval
- Built-in tools: shell, read_file, clipboard, web_search
- Tool UI: collapsible result cards, execution spinner, confirmation prompt
- Settings: enable toggle, max iterations, timeout, discovered tools list
- Plugin-style tool discovery: tools/<name>/spec.json + run executable - OpenAI and Gemini tool_calls integration with multi-turn loop - Confirmation system with allowlist (approve once, always allow, deny) - Generic tool:qualifier pattern for granular permissions (e.g. shell:ls) - Quote-aware shell tokenizer for safe compound command approval - Built-in tools: shell, read_file, clipboard, web_search - Tool UI: collapsible result cards, execution spinner, confirmation prompt - Settings: enable toggle, max iterations, timeout, discovered tools list
|
@j-1in - this PR modifies your plugin. Please review when you have a chance. |
Cleboost
left a comment
Cleboost
left a comment
There was a problem hiding this comment.
Here are some small improvements you can make 🙂 (I already did the bot work, but your PR is older than the bot deployment 😄)
| applyUiScale: false | ||
|
|
||
| ToolTip.visible: toolCountMouse.containsMouse | ||
| ToolTip.text: (pluginApi?.tr("chat.toolsAvailable") || "Tools available") + ": " + toolCount |
There was a problem hiding this comment.
When it comes to translations, you don't need to use fallback values anymore. So the following works:
// From:
pluginApi?.tr("key") || "Value"
// To this:
pluginApi?.tr("key")| } | ||
|
|
||
| NText { | ||
| text: pluginApi?.tr("chat.executingTools") || "Executing tools..." |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
| } | ||
|
|
||
| NText { | ||
| text: pluginApi?.tr("chat.toolConfirmTitle") || "Tool wants to run" |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
| spacing: Style.marginS | ||
|
|
||
| NButton { | ||
| text: pluginApi?.tr("chat.approveOnce") || "Approve Once" |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
| // Qualified: "Allow <tool:qualifier>" button | ||
| NButton { | ||
| visible: confirmRect.hasQualifier | ||
| text: (pluginApi?.tr("chat.allowCommand") || "Allow") + " `" + confirmRect.qualifiedKey + "`" |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
|
|
||
| NText { | ||
| visible: root.qualifiedEntries.length === 0 | ||
| text: pluginApi?.tr("settings.noAllowlistEntries") || "No rules yet. Rules are added when you approve tools in the chat." |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
| NTextInput { | ||
| id: newAllowlistInput | ||
| Layout.fillWidth: true | ||
| placeholderText: pluginApi?.tr("settings.allowlistAddPlaceholder") || "e.g. shell:ls, shell:git, shell:*" |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
| } | ||
|
|
||
| NButton { | ||
| text: pluginApi?.tr("settings.allowlistAdd") || "Add" |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
| label: pluginApi?.tr("settings.toolsDirectory") || "Tools Directory" | ||
| description: pluginApi?.tr("settings.toolsDirectoryDesc") || "Path to tools directory (leave blank for default)" |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
| // Tool Settings Section | ||
| // ================== | ||
| NText { | ||
| text: pluginApi?.tr("settings.toolsSection") || "Tool Use (Function Calling)" |
There was a problem hiding this comment.
As before you don't need translation fallbacks anymore
2 participants
