feat(activate-linux): add font size and margin configuration#409
feat(activate-linux): add font size and margin configuration#409thingpuisenhang wants to merge 3 commits intonoctalia-dev:mainfrom
Conversation
|
@pgattic - this PR modifies your plugin. Please review when you have a chance. |
|
Original creator of this plugin here. Overall, looks like a pretty good improvement! Despite your comment, it doesn't actually implement i18n for the additional options, it's only got English. I don't know what Noctalia does when a given language is missing, but if you can either add the required strings for those languages or verify that it'll work fine without them and amend your comment, that would be nice. Also, I did like it when it would update the plugin on every input to the fields, but removing that is understandable I guess? Idk what best practice is, but I'd like it to keep that functionality if it is allowed. |
I would argue that as a general rule of thumb, if it's your plugin you decide what is and isn't allowed (of course the maintainers will not allow malicious code and such but you get my point) |
…upport - Implement debounced saveSettings() for real-time updates - Add AI-generated translations for all supported languages (unverified) - Update manifest.json with new contributor and version
|
@pgattic Would you be able to review this to check if everything is how you would like to? :) |
3 participants
This PR adds configurable font sizes and margins to the Activate Linux plugin settings page. It also implements proper translation support for these new settings.