Add noctalia-calculator plugin by pir0c0pter0 · Pull Request #459 · noctalia-dev/noctalia-plugins

pir0c0pter0 · 2026-03-23T11:34:12Z

Summary

Theme-aware calculator plugin for Noctalia on Niri.

Full expression evaluation with operator precedence via pluginApi.loadHelper("AdvancedMath")
Bar widget with live result badge
Floating panel with 21-button grid and keyboard support
10-language i18n (en, pt, es, fr, de, it, ru, zh, ja, ko)
Settings: decimal precision (0-10), show/hide bar value

Preview

Keyboard support

0-9, +-*/, ., Enter, Backspace, Esc, F9 (toggle sign), %

Plugin structure

noctalia-calculator/
├── manifest.json
├── Main.qml
├── BarWidget.qml
├── Panel.qml
├── Settings.qml
├── i18n/ (en, pt, es, fr, de, it, ru, zh, ja, ko)
├── preview.png
├── LICENSE
└── README.md

Changes in latest commit

Removed local .gitignore (root repo already handles */settings.json)
Removed local AdvancedMath.js copy (uses pluginApi.loadHelper("AdvancedMath") from shell)
Removed unnecessary -0 guard in _sanitizeCurrentInput
Updated README with preview image, i18n info, and accurate file list

kevichi7 · 2026-03-23T11:43:03Z

was waiting for something like this - thanks

spiros132

Some feedback about the PR :)

spiros132 · 2026-03-23T12:11:58Z

noctalia-calculator/manifest.json

+    "plugins": []
+  },
+  "metadata": {
+    "commandPrefix": "calculator",


This is not needed since there is no LauncherProvider entry point.

spiros132 · 2026-03-23T12:15:28Z

noctalia-calculator/BarWidget.qml

+                "icon": "trash"
+            },
+            {
+                "label": pluginApi?.tr("bar.settings") ?? "Settings",


When it comes to translations we don't need to use fallbacks anymore. For example:

// From: pluginApi?.tr("key") ?? "Value" // To: pluginApi?.tr("key")

spiros132 · 2026-03-23T12:18:33Z

noctalia-calculator/Main.qml

+    function _sanitizeCurrentInput() {
+        if (currentInput === "" || currentInput === "-") return "0";
+        if (currentInput.endsWith(".")) return currentInput + "0";
+        if (currentInput === "-0") return "-0";


I'm not sure if this if statement is doing anything

This comment still persists. This if statement isn't exactly needed

spiros132 · 2026-03-23T12:24:03Z

noctalia-calculator/Main.qml

+        return _formatExpression(built);
+    }
+
+    function evaluate() {


The noctalia shell already contains a library for evaluating math expressions. It's the following file.

spiros132 · 2026-03-23T12:27:51Z

noctalia-calculator/Panel.qml

+                        radius: Style.radiusL
+                        color: Qt.alpha(Color.mPrimary, 0.08)
+                        border.color: root.activeFocus ? Qt.alpha(Color.mPrimary, 0.8) : Qt.alpha(Color.mOutline, 0.65)
+                        border.width: 1


Do not use hard-coded values, use the Style singleton instead

spiros132 · 2026-03-23T12:31:24Z

noctalia-calculator/README.md

+./remove.sh
+```
+
+This removes the plugin from Noctalia settings and unlinks it from the local plugin directory. The repository checkout itself is kept in place.


Here as well, no ./remove.sh needed

spiros132 · 2026-03-23T12:31:46Z

noctalia-calculator/README.md

+- `Settings.qml`: plugin settings UI
+- `install.sh`: install and register the plugin
+- `update.sh`: update from git and reinstall
+- `remove.sh`: unregister and unlink the plugin


These ./*.sh files don't exist

spiros132 · 2026-03-23T12:32:12Z

noctalia-calculator/Settings.qml

+    NToggle {
+        Layout.fillWidth: true
+        label: pluginApi?.tr("settings.show-bar") ?? "Show value in bar"
+        description: pluginApi?.tr("settings.show-bar-desc") ?? "Display the current value next to the calculator icon"


As before the translation feedbacks aren't needed

spiros132 · 2026-03-23T12:33:39Z

noctalia-calculator/Settings.qml

+        spacing: Style.marginS
+
+        NLabel {
+            label: (pluginApi?.tr("settings.precision") ?? "Decimal precision") + ": " + root.valuePrecision


Do not use concatenation when it comes to translations. Use translation interpolation instead. For example:

pluginApi?.tr("key", { "foo": "bar" })

spiros132 · 2026-03-23T12:34:44Z

noctalia-calculator/Settings.qml

+        Layout.fillWidth: true
+        label: pluginApi?.tr("settings.about") ?? "About"
+        description: (pluginApi?.tr("settings.developed-by") ?? "Developed by Pir0c0pter0")
+            + "<br>v" + (pluginApi?.manifest?.version ?? "1.0.0")


Here as well, no need for fallback and also use translation interpolation.

pir0c0pter0 · 2026-03-23T15:03:42Z

all done in commit 500bf36 — refactor: address PR review feedback for official merge

spiros132 · 2026-03-23T16:49:28Z

all done in commit 500bf36 — refactor: address PR review feedback for official merge

What do you mean by that? That particular commit hasn't been pushed to this PR

pir0c0pter0 · 2026-03-23T18:24:27Z

all the instructions are fixed in the last commit.

spiros132

Some more feedback about the PR :)

spiros132 · 2026-03-23T19:56:16Z

noctalia-calculator/.gitignore

You don't need a .gitignore file for the settings.json. That is already taken care of by the root .gitignore

spiros132 · 2026-03-23T19:57:16Z

noctalia-calculator/AdvancedMath.js

Do not copy the AdvancedMath.js library. Instead reference and import it in the files that it's required in from the noctalia-shell. That way if any update happens on that file you get the update as well.

spiros132 · 2026-03-23T19:58:07Z

noctalia-calculator/Main.qml

+    function _sanitizeCurrentInput() {
+        if (currentInput === "" || currentInput === "-") return "0";
+        if (currentInput.endsWith(".")) return currentInput + "0";
+        if (currentInput === "-0") return "-0";


This comment still persists. This if statement isn't exactly needed

spiros132 · 2026-03-23T20:00:00Z

noctalia-calculator/Main.qml

-            result = left / right;
+    function _evaluateExpression(expressionStr) {
+        try {
+            var math = pluginApi ? pluginApi.loadHelper("AdvancedMath") : null;


This function does not exist in the pluginApi. Did you try out the plugin and looked that it worked?

Yes, I tested the plugin and it works correctly. pluginApi.loadHelper() is implemented in PluginService.qml (lines 1227-1234) — it loads helpers from the _shellHelpers map, which includes AdvancedMath among others. The function returns the helper object or null if not found, and the calculator handles both cases.

No pluginApi.loadHelper function exists. Please fact check the AI / LLM before commenting so confidently!

Here is the link to that specific line quoted.

spiros132 · 2026-03-23T20:01:17Z

noctalia-calculator/preview.png

You still need a preview file for the plugin

The preview file has been included — preview.png is now in the plugin directory and visible in the PR description as well.

- Remove local .gitignore (root repo handles settings.json) - Remove local AdvancedMath.js copy (uses pluginApi.loadHelper) - Remove unnecessary -0 guard in _sanitizeCurrentInput - Update README with preview, i18n details, and accurate file list

Cleboost

Small fixes for French accents in i18n ;)

noctalia-calculator/i18n/fr.json

Cleboost · 2026-03-30T16:24:42Z

noctalia-calculator/i18n/fr.json

+  "settings": {
+    "about": "A propos",
+    "show-bar": "Afficher la valeur dans la barre",
+    "show-bar-desc": "Affiche la valeur actuelle a cote de l'icone de la calculatrice",


Suggested change

"show-bar-desc": "Affiche la valeur actuelle a cote de l'icone de la calculatrice",

"show-bar-desc": "Affiche la valeur actuelle a cote de l’icône de la calculatrice",

Co-authored-by: Cleboost <clement.balarot@gmail.com>

spiros132

This function still doesn't exist anywhere in the noctalia-shell

spiros132 · 2026-03-30T21:12:32Z

noctalia-calculator/Main.qml

+
+    function _evaluateExpression(expressionStr) {
+        try {
+            var math = pluginApi ? pluginApi.loadHelper("AdvancedMath") : null;


This function still doesn't exist anywhere in the code base.

feat: add noctalia-calculator plugin

3f966e8

spiros132 reviewed Mar 23, 2026

View reviewed changes

refactor: address PR review feedback and use pluginApi.loadHelper()

0738d02

spiros132 reviewed Mar 23, 2026

View reviewed changes

pir0c0pter0 and others added 2 commits March 23, 2026 17:29

docs: add calculator preview image

cd09b67

Ly-sec marked this pull request as draft March 28, 2026 14:46

Cleboost suggested changes Mar 30, 2026

View reviewed changes

pir0c0pter0 and others added 6 commits March 30, 2026 16:51

Update noctalia-calculator/i18n/fr.json

b96ee7e

Co-authored-by: Cleboost <clement.balarot@gmail.com>

Update noctalia-calculator/i18n/fr.json

57a6d61

Co-authored-by: Cleboost <clement.balarot@gmail.com>

Update noctalia-calculator/i18n/fr.json

36af406

Co-authored-by: Cleboost <clement.balarot@gmail.com>

Update noctalia-calculator/i18n/fr.json

295bc92

Co-authored-by: Cleboost <clement.balarot@gmail.com>

Update noctalia-calculator/i18n/fr.json

1ff3e5e

Co-authored-by: Cleboost <clement.balarot@gmail.com>

Update noctalia-calculator/i18n/fr.json

dff57f9

Co-authored-by: Cleboost <clement.balarot@gmail.com>

Cleboost approved these changes Mar 30, 2026

View reviewed changes

spiros132 reviewed Mar 30, 2026

View reviewed changes

	"show-bar-desc": "Affiche la valeur actuelle a cote de l'icone de la calculatrice",
	"show-bar-desc": "Affiche la valeur actuelle a cote de l’icône de la calculatrice",

Conversation

pir0c0pter0 commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Preview

Keyboard support

Plugin structure

Changes in latest commit

Uh oh!

kevichi7 commented Mar 23, 2026

Uh oh!

spiros132 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pir0c0pter0 commented Mar 23, 2026

Uh oh!

spiros132 commented Mar 23, 2026

Uh oh!

pir0c0pter0 commented Mar 23, 2026

Uh oh!

spiros132 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Cleboost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spiros132 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

pir0c0pter0 commented Mar 23, 2026 •

edited

Loading