Skip to content

Add update-widget plugin#511

Open
Astinator wants to merge 9 commits intonoctalia-dev:mainfrom
Astinator:main
Open

Add update-widget plugin#511
Astinator wants to merge 9 commits intonoctalia-dev:mainfrom
Astinator:main

Conversation

@Astinator
Copy link
Copy Markdown

Adds update-widget a plugin to allow you to view the number of available updates from the bar and see updated versions from the panel. Has optional flatpak update checking support.

preview

@kevichi7
Copy link
Copy Markdown
Contributor

would also be cool to add noctalia-shell specific updates here I guess (such as plugins or noctalia-qs). As a toggle though

@Astinator
Copy link
Copy Markdown
Author

Not quite sure how you would check for plugin updates but that sounds like a nice idea. Thanks!

Adds optional highlights to the bar widget if a Noctalia component has an update
Copy link
Copy Markdown
Contributor

@spiros132 spiros132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback about the PR :)

Adds missing bar widget properties, turns most logs info to debug and uses onToggled instead of a mouse area.
Copy link
Copy Markdown
Contributor

@spiros132 spiros132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, it looks great! :)

@ItsLemmy

@ItsLemmy
Copy link
Copy Markdown
Contributor

LGTM, my only concerns are :

  • this only works on Arch based distros and the plugin's title and readme should reflect that. "widget" is pretty generic term, so maybe call it "Arch updater" or something closer to it's actual functionality.
  • the squatting of the launcher provider keyword "refresh" which is also way too generic , >arch-update would be better. We have a PR coming in soon in the shell that allows custom aliases of commands so people will be able to do aliases easily, ex: >paru => >arch-update

@Astinator
Copy link
Copy Markdown
Author

Thanks for the feedback! I'll make changes to address those concerns.

Also changes the launcher commands and fixes a bug where the Noctalia update highlighting didn't have a fallback to the default manifest settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants