Add basic sanity checks in general-unbind-non-prefix-key #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noctuid
force-pushed
the
bugfix/unbind-non-prefix-guard
branch
5 times, most recently
from
a2c298c to
b76684f
Compare
Saw it failing when keymap was nil. Should do nothing in that case and not fail prematurely. Also fix CI.
noctuid
force-pushed
the
bugfix/unbind-non-prefix-guard
branch
from
b76684f to
7ba029e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw it failing when keymap was nil. Should do nothing in that case and not fail prematurely.