Skip to content

chore(cov): disable patch coverage #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025
Merged

chore(cov): disable patch coverage #324

merged 1 commit into from
Jun 29, 2025

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Jun 26, 2025

Although we haven’t reached 80% coverage yet, our patch coverage threshold has successfully served its purpose by encouraging meaningful test coverage in our PRs. Now that we’re above 70%, I’m confident we can continue to improve coverage even without enforcing the threshold.

@Copilot Copilot AI review requested due to automatic review settings June 26, 2025 02:35
@avivkeller avivkeller requested a review from a team as a code owner June 26, 2025 02:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the patch coverage requirement in the Codecov configuration to allow continued improvements without enforcing a per-PR threshold.

  • Removed the 80% patch coverage target and related TODO comments.
  • Added patch: false under status to disable patch coverage checks.
  • Left project coverage settings and TODO remarks in place.
Comments suppressed due to low confidence (2)

codecov.yml:4

  • Ensure that patch: false is indented at the same level as project under status, so the YAML parser correctly recognizes both keys.
    patch: false

codecov.yml:7

  • Update or remove this TODO since the rationale for project coverage thresholds has likely changed alongside disabling patch coverage enforcement.
        # TODO(@avivkeller): Once our coverage > 70%,

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e44f080). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage        ?   66.57%           
=======================================
  Files           ?       81           
  Lines           ?     6956           
  Branches        ?      339           
=======================================
  Hits            ?     4631           
  Misses          ?     2322           
  Partials        ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller merged commit e1494c6 into main Jun 29, 2025
9 checks passed
@avivkeller avivkeller deleted the avivkeller-patch-1 branch June 29, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants