test: ensure assertions are reachable in test/es-module
#60501
+692
−686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
esm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60501 +/- ##
==========================================
+ Coverage 88.05% 88.57% +0.52%
==========================================
Files 704 704
Lines 207857 207858 +1
Branches 39964 40055 +91
==========================================
+ Hits 183030 184114 +1084
+ Misses 16806 15771 -1035
+ Partials 8021 7973 -48 🚀 New features to boost your workflow:
|
atlowChemi
approved these changes
Nov 1, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
atlowChemi
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/60501 ✔ Done loading data for nodejs/node/pull/60501 ----------------------------------- PR info ------------------------------------ Title test: ensure assertions are reachable in `test/es-module` (#60501) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:must-call-mustCalls-esm -> nodejs:main Labels test, esm, author ready, needs-ci Commits 2 - test: ensure assertions are reachable in `test/es-module` - fixup! test: ensure assertions are reachable in `test/es-module` Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60501 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60501 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 30 Oct 2025 17:39:22 GMT ✔ Approvals: 1 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/60501#pullrequestreview-3407727421 ✘ This PR needs to wait 100 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-11-02T11:09:34Z: https://ci.nodejs.org/job/node-test-pull-request/70004/ - Querying data for job/node-test-pull-request/70004/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/19012562566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another followup of #60125