Skip to content

Conversation

@RaisinTen
Copy link
Member

This adds a diagnostics channel for tracking chunk additions to readable streams without having any side-effects on user code.

This is needed for #60483 (comment)

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Oct 31, 2025
@RaisinTen RaisinTen requested review from mcollina and ronag October 31, 2025 15:03
Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.58%. Comparing base (ba7cdf4) to head (1760239).
⚠️ Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60514      +/-   ##
==========================================
+ Coverage   88.56%   88.58%   +0.01%     
==========================================
  Files         704      704              
  Lines      207774   207868      +94     
  Branches    40027    40052      +25     
==========================================
+ Hits       184020   184138     +118     
+ Misses      15800    15766      -34     
- Partials     7954     7964      +10     
Files with missing lines Coverage Δ
lib/internal/streams/readable.js 96.22% <100.00%> (+0.02%) ⬆️

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RaisinTen RaisinTen closed this Oct 31, 2025
@RaisinTen RaisinTen deleted the add-dc-for-tracking-readable-stream-chunk-adds branch October 31, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants