Skip to content

build: expose libplatform symbols in shared libnode #61144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joyeecheung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: expose libplatform symbols in shared libnode #61144

joyeecheung wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Dec 21, 2025

This requires setting BUILDING_V8_PLATFORM_SHARED to expose the public symbols since we build with hidden visibility by default.

Fixes: #61102

@joyeecheung
build: expose libplatform symbols in shared libnode
abb78a9 
This requires setting BUILDING_V8_PLATFORM_SHARED to expose the
public symbols since we build with hidden visibility by default.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Dec 21, 2025
@joyeecheung joyeecheung mentioned this pull request Dec 21, 2025
Open
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2025

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20415476248

targos
targos approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

legendecas
legendecas reviewed Dec 22, 2025
View reviewed changes
tools/v8_gypfiles/v8.gyp
],
'direct_dependent_settings': {
'defines': [
'USING_V8_SHARED',
Copy link
Member

@legendecas legendecas Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add USING_V8_PLATFORM_SHARED here as well?

@jeroen jeroen mentioned this pull request Dec 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas left review comments

@targos targos targos approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linking error for libplatform as of 24.11.1

4 participants

@joyeecheung @nodejs-github-bot @targos @legendecas