Skip to content

test_runner: differentiate todo and failure styles #61564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MoLow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test_runner: differentiate todo and failure styles #61564

MoLow wants to merge 1 commit into from
+9 −6

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Jan 28, 2026 •
edited
Loading

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2026

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 28, 2026
JakobJingleheimer
JakobJingleheimer reviewed Jan 28, 2026
View reviewed changes
@MoLow MoLow changed the title test_runner: seperate style for expected failure and todo than failure test_runner: differentiate todo and failure styles Jan 28, 2026
JakobJingleheimer
JakobJingleheimer approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@codecov
Copy link

codecov bot commented Jan 28, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (79ddd1b) to head (fbec293).
⚠️ Report is 103 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61564      +/-   ##
==========================================
+ Coverage   88.53%   89.77%   +1.23%     
==========================================
  Files         704      673      -31     
  Lines      208876   203823    -5053     
  Branches    40330    39173    -1157     
==========================================
- Hits       184937   182972    -1965     
+ Misses      15922    13186    -2736     
+ Partials     8017     7665     -352
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/utils.js 95.14% <100.00%> (+0.14%) ⬆️

... and 145 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 29, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71115/

@atlowChemi atlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 29, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71119/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 29, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71120/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow @nodejs-github-bot @benjamingr @JakobJingleheimer @atlowChemi