-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(blog): Emelia Smith Pride Post #7907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@nodejs/TSC @nodejs/marketing FYI |
Co-authored-by: Aviv Keller <me@aviv.sh> Signed-off-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
Co-authored-by: Aviv Keller <me@aviv.sh> Signed-off-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
Signed-off-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7907 +/- ##
==========================================
+ Coverage 75.33% 75.40% +0.07%
==========================================
Files 101 96 -5
Lines 8326 8355 +29
Branches 218 219 +1
==========================================
+ Hits 6272 6300 +28
- Misses 2052 2053 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There! Ended up checking the repo out and running the formatting and tests. I did have a minor issue getting pnpm to work, it didn't seem to like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOVE it 🫶🏻
Thanks for the proof-reading, I'll fix up the issues in a bit. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Let's publish this on Monday to coordinate with @nodejs/marketing |
Small ask on the publishing, can we do it between 7am ET and 4pm ET? That'll give me time to have had a coffee before I start getting replies (because I'm certain that's going to happen) and allow me time to respond before heading to sleep that day. |
We got you :) |
Also, any/all harassment on Node.js official communication channels (GitHub, Discord, Slack, etc) will not be tolerated, so make sure to report those to organization members, who can moderate accordingly. |
Yeah, I'm expecting it on my github, mastodon and bluesky accounts tbh, and have already advised mods of the mastodon server I'm on that harassment may happen due to this article being published. Not sure what I can do for GitHub / Bluesky to mitigate though I've been hearing that y'all have got this on the official accounts for the project lately, so thinking ahead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm unrelated to anything, got here from the blog post and saw this PR and noticed this possible miss)
Wonderfully written; thank you for sharing your story!
There we go, I think that's now the final copy, after someone noticed I'd managed to duplicate a paragraph by accident when editing. |
@@ -0,0 +1,37 @@ | |||
--- | |||
date: '2025-06-28T13:00:00.000Z' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI to whoever lands this–please update this before land + lock this PR
Description
Here's my response to the call for stories from the latest blog post.
Thanks for starting this initiative, I don't tell my story anywhere near often enough.
Validation
Yes, this is validating ;)
Related Issues
None anymore.
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.I wrote this in my notes, and then created this PR via the GitHub user interface, so it may not be inline with the repository's code formatting — it'd be helpful if a maintainer reviewed and fixed any formatting issues, first time contributing something in a bit of a quick fashion, as I wanted to share this before Pride Month ended.