-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(remark-lint): add strict rules #8106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@@ -61,6 +63,7 @@ export default (options = {}) => ({ | |||
{ yes: 'Unix' }, | |||
{ yes: 'Valgrind' }, | |||
{ yes: 'V8' }, | |||
{ yes: 'npm' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ethan-Arrowood is this what you had in mind?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8106 +/- ##
==========================================
+ Coverage 75.88% 76.03% +0.15%
==========================================
Files 112 114 +2
Lines 9433 9503 +70
Branches 303 313 +10
==========================================
+ Hits 7158 7226 +68
- Misses 2274 2275 +1
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
@nodejs/web what other lint rules are needed? I'm thinking:
What else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOC, when we add new rules, in which repositories are they being applied? doc-kit? So it means Node's core API docs? Shouldn't then any PR to remark-lint actually require nodejs/collaborators as code owners?
My plan is for these to be applied to The previous implementation did not have any CODEOWNERS, thus, this is the same, however, that can change |
Follow-up #8057.
Now that we have a basic package, this PR modifies the rules to use
@nodejs/doc-kit
's functionality, ensuring that any changes their get reflected in the linter.Why was this separate from #8057? I wanted a version (
1.0.0
) which is almost a drop-in replacement for the original linter, without relying on@nodejs/doc-kit
, in case something broke.