Skip to content

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Aug 23, 2025

Orama relies on /next-data/api-data and /next-data/page-data, which no other part of the site needs. This could probably be removed from the server entirely, and done locally.

Successful Orama Sync = https://github.com/nodejs/nodejs.org/actions/runs/17176946135/job/48734137782?pr=8107

@avivkeller avivkeller requested review from a team as code owners August 23, 2025 01:45
Copy link

vercel bot commented Aug 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Aug 26, 2025 1:07am

@avivkeller
Copy link
Member Author

avivkeller commented Aug 23, 2025

See the new pull_request check running @ https://github.com/nodejs/nodejs.org/actions/runs/17169658343/job/48716786826?pr=8107

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Aug 23, 2025
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 96.87500% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.59%. Comparing base (a9e90a2) to head (684f399).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/site/scripts/orama-search/get-documents.mjs 92.95% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8107      +/-   ##
==========================================
+ Coverage   75.88%   76.59%   +0.70%     
==========================================
  Files         112      114       +2     
  Lines        9433     9569     +136     
  Branches      303      317      +14     
==========================================
+ Hits         7158     7329     +171     
+ Misses       2274     2239      -35     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 23, 2025
Copy link
Contributor

github-actions bot commented Aug 23, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 97 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 94 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 100 🔗

@avivkeller avivkeller marked this pull request as draft August 23, 2025 12:26
@avivkeller avivkeller changed the title feat(ci): run build on pull_request feat(Orama): don't rely on static build Aug 23, 2025
Signed-off-by: Aviv Keller <me@aviv.sh>
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few concerns regarding code-smell, use of more stable APIs (such as ASTs) and maybe even using our existing doc-kit for this. Also, can you please add tests for this script? I know there were none, but I actually want to verify this is working as expected from now on....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants