-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(Orama): don't rely on static build #8107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
See the new |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8107 +/- ##
==========================================
+ Coverage 75.88% 76.59% +0.70%
==========================================
Files 112 114 +2
Lines 9433 9569 +136
Branches 303 317 +14
==========================================
+ Hits 7158 7329 +171
+ Misses 2274 2239 -35
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Lighthouse Results
|
799f45e
to
dbd53ad
Compare
da061c5
to
91af1d2
Compare
0c01426
to
48eeaff
Compare
0624938
to
7d0af81
Compare
Signed-off-by: Aviv Keller <me@aviv.sh>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few concerns regarding code-smell, use of more stable APIs (such as ASTs) and maybe even using our existing doc-kit for this. Also, can you please add tests for this script? I know there were none, but I actually want to verify this is working as expected from now on....
Orama relies on
/next-data/api-data
and/next-data/page-data
, which no other part of the site needs. This could probably be removed from the server entirely, and done locally.Successful Orama Sync = https://github.com/nodejs/nodejs.org/actions/runs/17176946135/job/48734137782?pr=8107