Skip to content

Conversation

@bmuenzenmeyer
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer commented Jan 30, 2026

Description

I couldn't install main trying to address #8574 without this. Is something wrong with my environment? I don't think so??

Validation

➜  nodejs.org git:(8575-install-nodejs-dockit) ✗ pnpm i
Scope: all 6 workspace projects
Lockfile is up to date, resolution step is skipped
Already up to date
. prepare$ husky
└─ Done in 243ms
Done in 2.8s using pnpm v10.28.0

Related Issues

closes #8575

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner January 30, 2026 23:11
Copilot AI review requested due to automatic review settings January 30, 2026 23:11
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner January 30, 2026 23:11
@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jan 30, 2026 11:11pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an installation failure by adding @nodejs/doc-kit to the onlyBuiltDependencies allowlist in the pnpm workspace configuration. This change allows the git-hosted @nodejs/doc-kit package to execute build scripts during installation, which is required because it's a binary package.

Changes:

  • Added @nodejs/doc-kit to the onlyBuiltDependencies list in pnpm-workspace.yaml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.00%. Comparing base (5046ba5) to head (64230cf).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8576      +/-   ##
==========================================
+ Coverage   74.95%   75.00%   +0.04%     
==========================================
  Files         103      103              
  Lines        9037     9037              
  Branches      312      311       -1     
==========================================
+ Hits         6774     6778       +4     
+ Misses       2261     2257       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.74 MB
New Total Size 3.74 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/f79446d8d21af36f.js 206.15 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/49847f5e28b57619.js 206.15 KB

@ovflowd
Copy link
Member

ovflowd commented Jan 30, 2026

cc @avivkeller what is the @nodejs/doc-kit pkg?

@bmuenzenmeyer
Copy link
Contributor Author

cc @avivkeller what is the @nodejs/doc-kit pkg?

https://github.com/nodejs/doc-kit 😄

@avivkeller
Copy link
Member

cc @avivkeller what is the @nodejs/doc-kit pkg?

We use doc-kit here to lint the markdown files in core once doc-kit is used there.

It was decided a while ago that linting should be separate from generation, so we broke it into multiple packages.

@ovflowd
Copy link
Member

ovflowd commented Jan 31, 2026

cc @avivkeller what is the @nodejs/doc-kit pkg?

https://github.com/nodejs/doc-kit 😄

Thats not what I meant, like I don't recall ever publishing a package to npm 😅

@ovflowd
Copy link
Member

ovflowd commented Jan 31, 2026

cc @avivkeller what is the @nodejs/doc-kit pkg?

We use doc-kit here to lint the markdown files in core once doc-kit is used there.

It was decided a while ago that linting should be separate from generation, so we broke it into multiple packages.

Ah so the core linting package is within doc-kit? Gotcha

@avivkeller
Copy link
Member

Thats not what I meant, like I don't recall ever publishing a package to npm 😅

It's not published to npm, but that is what the package is named. It's downloaded from git, with that name set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install fails

3 participants