-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
adds @nodejs/doc-kit as an allow-lists dependency #8576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an installation failure by adding @nodejs/doc-kit to the onlyBuiltDependencies allowlist in the pnpm workspace configuration. This change allows the git-hosted @nodejs/doc-kit package to execute build scripts during installation, which is required because it's a binary package.
Changes:
- Added
@nodejs/doc-kitto theonlyBuiltDependencieslist inpnpm-workspace.yaml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8576 +/- ##
==========================================
+ Coverage 74.95% 75.00% +0.04%
==========================================
Files 103 103
Lines 9037 9037
Branches 312 311 -1
==========================================
+ Hits 6774 6778 +4
+ Misses 2261 2257 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
|
cc @avivkeller what is the @nodejs/doc-kit pkg? |
|
We use doc-kit here to lint the markdown files in core once doc-kit is used there. It was decided a while ago that linting should be separate from generation, so we broke it into multiple packages. |
Thats not what I meant, like I don't recall ever publishing a package to npm 😅 |
Ah so the core linting package is within doc-kit? Gotcha |
It's not published to npm, but that is what the package is named. It's downloaded from git, with that name set |
Description
I couldn't install
maintrying to address #8574 without this. Is something wrong with my environment? I don't think so??Validation
Related Issues
closes #8575
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.