Fix aggregations check in the search function.#14
Open
iKristjan wants to merge 1 commit intonodespark:5.xfrom
Open
Fix aggregations check in the search function.#14iKristjan wants to merge 1 commit intonodespark:5.xfrom
iKristjan wants to merge 1 commit intonodespark:5.xfrom
Conversation
|
Hello, Faced the same issue adding custom/nested aggs. WIll be nice to have this pull requested applied. Regards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aggregations are actually stored in
$params['body']['aggs'], not in$params['aggs'].Without this bugfix,
aggsalways gets rebuilt right before search. Hence making all aggregations altering void (e.g. altering$params['body']['aggs']inhook_elasticsearch_connector_search_api_query_alter()).