Handle qualified table names #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, Prisma is generating SQL queries where table names are prefixed with a schema name, e.g.:
This means that the regex in
getTableFromQuerywouldn't match, and the adapter would fallback to non-declared types. (Which then would break handling ofDATETIMEcolumns, since these appear as numbers at run-time...)I propose the change below, to also match qualified table names, and then using the form
PRAGMA ${tableInfo.schema}.table_info(${tableInfo.table})to get declared types.