Skip to content

refactor: remove deprecated CacheExtension from Ariadne adapter#20

Merged
nogueira-raphael merged 1 commit intomainfrom
refactor/remove-deprecated-cache-extension
Feb 15, 2026
Merged

refactor: remove deprecated CacheExtension from Ariadne adapter#20
nogueira-raphael merged 1 commit intomainfrom
refactor/remove-deprecated-cache-extension

Conversation

@nogueira-raphael
Copy link
Copy Markdown
Owner

Summary

  • Remove CacheExtension class and create_cache_extension function from the Ariadne adapter
  • Remove src/cacheql/adapters/ariadne/extension.py entirely
  • Remove 9 associated integration tests (TestCacheExtension, TestCacheExtensionWithVariables)
  • Update src/cacheql/__init__.py docstring to reference CachingGraphQL instead of CacheExtension

CacheExtension was deprecated because Ariadne's extension system is synchronous and doesn't properly await async cache operations. CachingGraphQL is the recommended replacement.

Test plan

  • All 130 tests passing (9 removed with the class)
  • mypy clean
  • Verified no production code depends on CacheExtension (Strawberry's CacheExtension is unaffected)

CacheExtension was deprecated because Ariadne's extension system is
synchronous and doesn't properly await async cache operations.
CachingGraphQL is the recommended replacement.
@nogueira-raphael nogueira-raphael force-pushed the refactor/remove-deprecated-cache-extension branch from a37756d to 8d55dff Compare February 15, 2026 11:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.64%. Comparing base (94830c5) to head (8d55dff).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   79.12%   80.64%   +1.51%     
==========================================
  Files          34       33       -1     
  Lines        1025      904     -121     
  Branches      162      136      -26     
==========================================
- Hits          811      729      -82     
+ Misses        175      152      -23     
+ Partials       39       23      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nogueira-raphael nogueira-raphael merged commit 6bd0e65 into main Feb 15, 2026
7 checks passed
@nogueira-raphael nogueira-raphael deleted the refactor/remove-deprecated-cache-extension branch February 15, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant