refactor: remove deprecated CacheExtension from Ariadne adapter#20
Merged
nogueira-raphael merged 1 commit intomainfrom Feb 15, 2026
Merged
Conversation
2 tasks
CacheExtension was deprecated because Ariadne's extension system is synchronous and doesn't properly await async cache operations. CachingGraphQL is the recommended replacement.
a37756d to
8d55dff
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 79.12% 80.64% +1.51%
==========================================
Files 34 33 -1
Lines 1025 904 -121
Branches 162 136 -26
==========================================
- Hits 811 729 -82
+ Misses 175 152 -23
+ Partials 39 23 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CacheExtensionclass andcreate_cache_extensionfunction from the Ariadne adaptersrc/cacheql/adapters/ariadne/extension.pyentirelyTestCacheExtension,TestCacheExtensionWithVariables)src/cacheql/__init__.pydocstring to referenceCachingGraphQLinstead ofCacheExtensionCacheExtensionwas deprecated because Ariadne's extension system is synchronous and doesn't properly await async cache operations.CachingGraphQLis the recommended replacement.Test plan
CacheExtension(Strawberry'sCacheExtensionis unaffected)