AMDXDNA support #431
Draft
AMDXDNA support #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngryLoki
reviewed
Dec 7, 2025
src/utils/process.rs
Outdated
| .args(["--host", proxy_path.as_str()]) | ||
| .args([ | ||
| &format!( | ||
| "--env=RUST_LOG={}", |
There was a problem hiding this comment.
I see error: unexpected argument '--env' found in the output.
Owner
Author
There was a problem hiding this comment.
Can you please send me the whole output and when it's written to it?
There was a problem hiding this comment.
error: unexpected argument '--env' found
Usage: resources-processes [OPTIONS]
For more information, try '--help'.
and nothing in apps/processes tabs after that.
I'll submit a PR, there are multiple issues other than that.
1. fdinfo collection only accepted DRM devices (major 226), but amdxdna uses the accel subsystem (major 261) 2. Driver name in fdinfo is "amdxdna_accel_driver", not "amdxdna" 3. Memory usage was unavailable because amdxdna doesn't expose it via sysfs, only via per-process fdinfo 4. There is no "--env" parameter in resources-processes This change was tested against the latest release of amdxdna driver, which is massively different from the driver shipped in Linux kernel. Maybe older driver uses "amdxdna" instead of "amdxdna_accel_driver". However, as new software works only with the new driver, I don't even think it is possible to test something with original driver. More details: https://wiki.gentoo.org/wiki/User:Lockal/AMDXDNA#Kernel Another note: Temperature, power, and frequency remain N/A as amdxdna does not expose hwmon interface (at least for my Asus ROG Z13 device). Maybe it makes sense to remove these fields from UI.
Driver exposes 2 values via DRM_AMDXDNA_QUERY_CLOCK_METADATA: "MP-NPU clock" and "H clock". Device has multiple power profiles, which switches both of them. Examples: ``` [Power Mode] Mode ID: 1 Mode Name: POWERSAVER [Clock Frequencies] MP-NPU Clock: 396 MHz H Clock: 792 MHz ``` ``` [Power Mode] Mode ID: 4 Mode Name: TURBO [Clock Frequencies] MP-NPU Clock: 1267 MHz H Clock: 1800 MHz ``` There is no description about these abbreviations, but it looks like H is hardware, MP is memory port, so these values are mapped to core_frequency/memory_frequency functions.
Fix amdxdna collection and aggregation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #417