Skip to content
This repository was archived by the owner on Aug 19, 2020. It is now read-only.

Conversation

@localhostdotdev
Copy link

@localhostdotdev localhostdotdev commented Apr 16, 2019

introduced in ruby 2.2: https://www.honeybadger.io/blog/ruby-unicode-normalization/ (2.3 just got EOL)

about the safe_load, if doesn't change anything as it's just data files, I just don't like "eval"s in my code :)

also this doesn't work in rails 6 at least because of the ActiveSupport normalize method that got renamed

DEPRECATION WARNING: ActiveSupport::Multibyte::Chars#normalize is deprecated and will be removed from Rails 6.1. Use #unicode_normalize(:nfkc) instead.
@justisb
Copy link

justisb commented Oct 26, 2019

Without this patch, on Rails 6.0 this deprecation warning will appear whenever to_ascii is called:

DEPRECATION WARNING: ActiveSupport::Multibyte::Chars#normalize is deprecated and will be removed from Rails 6.1. Use #unicode_normalize(:nfc) instead.

@jrochkind
Copy link
Collaborator

This repo hasn't had any activity in some years. It looks like I may be a committer -- I don't remember how that happened!

But I'm not an 'owner' who can add other committers/owners. And I haven't looked at this code and don't think I currently use it.

If @norman is around, I wonder if they would consider making other people committers/owners to maintain the gem? I am not sure if it currently really has any active maintainers.

If we don't hear from @norman, those interested in working on it (perhaps those writing PR's) might consider a fork?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants