ui/ws: deregister epoch_match_summary route #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norwnd
commented
Mar 20, 2023
| // Handle the initial candlestick data. | ||
| ws.registerRoute(candlesRoute, (data: BookUpdate) => { this.handleCandlesRoute(data) }) | ||
| // Handle the candles update on the 'candles' route. | ||
| // Handle the candles update. |
Owner
Author
There was a problem hiding this comment.
These comments seems kinda mixed (some refer to ui<->dexc routes, others refer to dexc<->server ones), easier more robust way to go about it is to just get rid of the duplicated part (actual route name) that can easily get out of date, which is why I update these comments like this here.
norwnd
force-pushed
the
master
branch
4 times, most recently
from
ad9d264 to
e298e04
Compare
norwnd
force-pushed
the
master
branch
5 times, most recently
from
f9959eb to
a66bbae
Compare
norwnd
force-pushed
the
master
branch
3 times, most recently
from
e3c487c to
333e9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent with other order-book-related routes, it seems there is no need to keep handling
epoch_match_summarywhen navigated away from/marketspage.